Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quote characters (") not able to be used in commit messages #433

Closed
raymond-rebbeck opened this issue Jul 16, 2024 · 4 comments
Closed
Assignees
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)

Comments

@raymond-rebbeck
Copy link
Contributor

raymond-rebbeck commented Jul 16, 2024

Using a double quote character in a commit message results in an error:
double-quote-error

This is the commit message used to produce the above error, appears as though double quotes may not be getting escaped properly:
test-commit

This is on latest latest main branch commit with d0b761a from PR #432 on top.

@isc-hwojnick isc-hwojnick self-assigned this Jul 16, 2024
@isc-hwojnick isc-hwojnick added bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) labels Jul 16, 2024
@isc-hwojnick isc-hwojnick added this to the Summer 2024 Improvements milestone Jul 16, 2024
@isc-pbarton
Copy link
Collaborator

PR #434 is a workaround that should be removed once we have a full fix for this issue.

@isc-tleavitt
Copy link
Collaborator

From a design standpoint, I think we need a new API in WebUIDriver that allows arguments to be passed as an array and autoquoted by $zf(-100). We can start out using it for commit and eventually convert everything else over too.

@isc-tleavitt
Copy link
Collaborator

And this should be part of the 2.4.1 release.

@isc-hwojnick
Copy link
Contributor

resolved through the new API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)
Projects
None yet
Development

No branches or pull requests

4 participants