Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync operation does not properly handle file rename #496

Closed
isc-pbarton opened this issue Sep 25, 2024 · 2 comments · Fixed by #517
Closed

Sync operation does not properly handle file rename #496

isc-pbarton opened this issue Sep 25, 2024 · 2 comments · Fixed by #517
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) usability

Comments

@isc-pbarton
Copy link
Collaborator

For example, on a remote repository rename an HL7 schema with extension .HL7 to have extension .hl7. Configure Basic mode on an IRIS instance so sync will merge changes from that branch on the remote repository. Running the Sync operation does not properly import the new .hl7 file.

@isc-tleavitt isc-tleavitt added bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) usability labels Sep 26, 2024
@isc-tleavitt isc-tleavitt added this to the Q3/Q4 2024 Targets milestone Sep 26, 2024
@isc-etamarch
Copy link
Collaborator

@isc-pbarton I think that this was resolved with PR #508, though want to make sure that you aren't seeing the issue anymore

@isc-tleavitt
Copy link
Collaborator

isc-tleavitt commented Oct 3, 2024

@isc-etamarch this is a distinct issue. If you change the file extension the git pull output will have something like:
/data/hl7/{Foo.HL7 -> Foo.hl7}
Which we need to interpret as "Foo.HL7 (in the database) was modified and needs to be reloaded into IRIS"

This could potentially be trickier, like:
/data/hl7/{Foo.HL7 -> Bar.hl7}
Which we would need to interpret into internal names as "Foo.HL7 was deleted and needs to be deleted in IRIS; Bar.HL7 was added and needs to be loaded into IRIS."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers) usability
Projects
None yet
3 participants