Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML completion for %Studio.AbstractDocument subclasses #334

Closed
isc-tleavitt opened this issue Jun 10, 2024 · 2 comments
Closed

XML completion for %Studio.AbstractDocument subclasses #334

isc-tleavitt opened this issue Jun 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@isc-tleavitt
Copy link

%Studio.AbstractDocument has Projection RegisterExtension As %Projection.StudioDocument which defines:

/// Schema associated with this document type, used by Studio Assist
Parameter XMLNamespace As STRING;

Studio used to support this for editing of "Other" document types but it actually appears to be broken in latest Studio (and this was always a little finicky, in my recollection).

Discussed with @isc-bsaviano - I'd love to have this both for the built-in types (e.g., .DFI, .LUT) and for user-space types (practically speaking, just .ZPM from https://github.com/intersystems/ipm)

@isc-tleavitt isc-tleavitt changed the title Completion for %Studio.AbstractDocument subclasses XML completion for %Studio.AbstractDocument subclasses Jun 10, 2024
@isc-bsaviano
Copy link
Contributor

This would be tricky to add. The Language Server declares the languages and URI schemes that it supports on activation. If a file doesn't match any of those tuples, VS Code won't ask our extension for intellisense requests for that document. Therefore, we'd need to declare the file extensions we support up front. We'd also need to parse those files to get the semantic tokens and will have to fail gracefully for all the other intellisense requests for those documents that we don't want to answer. I will discuss this with @isc-rsingh but I don't think there's enough value here to be worth the development effort.

@isc-bsaviano
Copy link
Contributor

I discussed this with Raj and we both feel that this change won't bring enough benefit to be worth the effort.

@isc-bsaviano isc-bsaviano closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants