Entity#serializable_hash must also check if attribute is generated by a user supplied block #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 20, 2012 19:42
…returned by a block (therefore absent from the object) would not be serialized
| @@ -252,6 +252,9 @@ | |||
| subject{ fresh_class.new(model) } | |||
|
|
|||
| describe '#serializable_hash' do | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Space is cheap, but not that cheap :)
|
Thanks, merging. |
dblock
added a commit
that referenced
this pull request
Jul 21, 2012
Entity#serializable_hash must also check if attribute is generated by a user supplied block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the latest updates to master with my app and ran into this issue. One of my entities contains a links attribute generated by a block, like this:
With #203 the :links attribute was not serialized.