Explicit return calls do not raise LocalJumpError #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of calling instance_eval on the block passed into Endpoint#initialize, create an anonymous UnboundMethod with the block as the method body. When executing the block bind the instance of Endpoint to the UnboundMethod and call it. This behavior and solution is taken from Sinatra. This solution also makes it possible to pass the values of Endpoint#params as arguments to the block. That feature is not present in this commit, but is trivial to implement.
|
|
dblock
added a commit
that referenced
this pull request
Nov 1, 2012
Explicit return calls do not raise LocalJumpError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of calling instance_eval on the block passed into
Endpoint#initialize, create an anonymous UnboundMethod with the block asthe method body. When executing the block bind the instance of Endpoint
to the UnboundMethod and call it.
This behavior and solution is taken from Sinatra.
This solution also makes it possible to pass the values of
Endpoint#paramsas arguments to the block. That feature is not presentin this commit, but is trivial to implement.