-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance respond_to? method #62
Conversation
…ons::MethodWriter#respond_to? and Hashie::Extensions::MethodQuery#respond_to? so that it supports the optional include_private argument - needed to work properly with some other modules like ActiveModel::Validations
Could you link me to the docs where |
Hy @jch, thanks for answering. Actually this is how the So when I tried to use the This issue is similar to #20 (same problem, same fix). So please accept this pull request :) |
@dlupu it would be great if you add some specs for that code :) |
Sorry this took so long to get around to. I just got commit access to clean things up. Thanks again for the pull! 🍻 |
Oops, looks like this does not work on ruby 1.8 https://travis-ci.org/intridea/hashie/builds/4736037. I'm going to revert the change, but feel free to open another pull if you find a better fix. |
I've merged the change back in. It turns out the problem was from another commit. See #74 |
This reverts commit 6af738f.
...::MethodWriter#respond_to? and Hashie::Extensions::MethodQuery#respond_to? so that it supports the optional include_private argument - needed to work properly with some other modules like ActiveModel::Validations