Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"com\intuit\..." prefixes on class types #425

Open
themightychris opened this issue Oct 23, 2021 · 3 comments
Open

"com\intuit\..." prefixes on class types #425

themightychris opened this issue Oct 23, 2021 · 3 comments

Comments

@themightychris
Copy link

What's with all the properties being declared with types like com\intuit\schema\finance\v3\IPPReferenceType:

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/master/src/Data/IPPSalesTransaction.php#L71

When the namespace for IPPReferenceType is QuickBooksOnline\API\Data:

https://github.com/intuit/QuickBooks-V3-PHP-SDK/blob/master/src/Data/IPPReferenceType.php

This makes it impossible for a project setting these properties to pass static analysis without tons of exceptions

@kkmuffme
Copy link

kkmuffme commented Mar 5, 2022

This is incredibly annoying, please merge the PR I provided.

@kkmuffme
Copy link

Fyi: the reason it's there is bc Bind.php could use it to map it against the XML schema, but that's not implemented anyway

@kkmuffme
Copy link

kkmuffme commented Oct 29, 2023

Btw this won't be fixed ever, as they use it as a namespace prefix and the SDK is super buggy atm.
See #505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants