Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question about merging a PR in a pre-release branch #1737

Closed
myndelx opened this issue Jan 21, 2021 · 3 comments · Fixed by #1738
Closed

Question about merging a PR in a pre-release branch #1737

myndelx opened this issue Jan 21, 2021 · 3 comments · Fixed by #1738
Labels
released This issue/pull request has been released.

Comments

@myndelx
Copy link
Contributor

myndelx commented Jan 21, 2021

When merging a PR with a label that has a releaseType: none (e.g. internal) in a pre-release branch (e.g. next), the yarn auto shipit command will still trigger a new pre-release (e.g. mypkg-1.0.0-next.1) whereas if I do the same on the master branch, no new release will be triggered, because of the releaseType: none. Is it the normal behavior? Why this difference?
@hipstersmoothie
Copy link
Collaborator

This is a great callout! They none labels should behave the same on a prerelease branch.

@hipstersmoothie hipstersmoothie mentioned this issue Jan 21, 2021
Merged
5 tasks
@adierkens
Copy link
Collaborator

🚀 Issue was released in v10.12.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jan 21, 2021
@myndelx
Copy link
Contributor Author

myndelx commented Jan 22, 2021

Thanks you so much @hipstersmoothie for your reactivity! 💪

@hipstersmoothie hipstersmoothie mentioned this issue Feb 4, 2021
Merged
6 tasks
@hipstersmoothie hipstersmoothie mentioned this issue Feb 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

respect skip and none releases for prereleases intuit/auto
3 participants
@hipstersmoothie @adierkens @myndelx