Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release changlog should show full PR title when it contains & (ampersand) #2460

Closed
MrHash opened this issue May 7, 2024 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@MrHash
Copy link

MrHash commented May 7, 2024

Describe the bug

PR title is missing in release changelog when the title contains square brackets.

To Reproduce

Run shipit to create a release from a squash merge containing a conventional or other commit followed by square brackets: e.g. fix: [ref-xzy] fixing thing & other

The release changelog shows: fix: #prnumber (author)

Expected behavior

The release changelog should show: fix: [ref-xzy] fixing a thing & other #prnumber (author)

Additional context

@MrHash MrHash added the bug Something isn't working label May 7, 2024
@MrHash MrHash changed the title Release changlog should show full PR title when it contains square brackets Release changlog should show full PR title when it contains & (ampersand) May 7, 2024
@tlkiong
Copy link

tlkiong commented Dec 12, 2024

@MrHash can you share your config or even better a minimally repo that reproduce the issue?
Mine is showing fix: [ref-xzy] fixing a thing & other #prnumber (author) with zero configuration

@MrHash
Copy link
Author

MrHash commented Dec 12, 2024

here's the .autorc, i think the bug is in the conventional commits plugin, i remember looking at it, should have linked the code

{
  "plugins": [
    "git-tag",
    "conventional-commits",
    "first-time-contributor"
  ],
  "shipit": {
    "noChangelog": true
  }
}

@tlkiong
Copy link

tlkiong commented Dec 16, 2024

just to debug a bit.
What if you remove:

"shipit": {
  "noChangelog": true
}

@MrHash
Copy link
Author

MrHash commented Dec 23, 2024

nothing really, that just disables creation of changelog file in root, not the release notes. maybe you can adjust the tests

@MrHash
Copy link
Author

MrHash commented Dec 23, 2024

TBH this is an old issue, i'm not sure if it's valid anymore. I think best to close until i see it again. thanks anyway

@MrHash MrHash closed this as completed Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants