Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Transport #97

Closed
haislip opened this issue Oct 5, 2020 · 4 comments
Closed

PDF Transport #97

haislip opened this issue Oct 5, 2020 · 4 comments

Comments

@haislip
Copy link
Contributor

haislip commented Oct 5, 2020

This library currently does not seem to actually work when pulling the generated PDF files from an environment. It's relying on the default transport options from the popsicle libraries, which is text. This means that we get a text representation of the PDF instead of the actual buffer that we need in order to save the file once we've received it. If you save/view the PDF response without this, it just appears as a blank document.

I've hacked working solution together here that gets this to work by allowing the user to pass in the transport directly (and defaults back to text when it's not provided).

@abisalehalliprasan
Copy link
Collaborator

abisalehalliprasan commented Oct 6, 2020

Thanks, @haislip for coming up with a quick fix. We are currently opening up our SDK's for contributions for the month of october : hacktoberfest.

As you have already provided the suggestion Could you create a PR, please?

@haislip
Copy link
Contributor Author

haislip commented Oct 6, 2020

Hacktastic: #98

@abisalehalliprasan
Copy link
Collaborator

@haislip . Thanks for the contribution. Will review the PR's soon 🚀

@ghost
Copy link

ghost commented Oct 30, 2020

@abisalehalliprasan Is there any possibility you can review and merge this?

/v3/company/${companyID}/invoice/${invoiceId}/pdf Download pdf API is really not working without this.

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants