-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDF Transport #97
Comments
Thanks, @haislip for coming up with a quick fix. We are currently opening up our SDK's for contributions for the month of october : hacktoberfest. As you have already provided the suggestion Could you create a PR, please? |
Hacktastic: #98 |
@haislip . Thanks for the contribution. Will review the PR's soon 🚀 |
@abisalehalliprasan Is there any possibility you can review and merge this?
Many thanks! |
This library currently does not seem to actually work when pulling the generated PDF files from an environment. It's relying on the default transport options from the popsicle libraries, which is
text
. This means that we get a text representation of the PDF instead of the actual buffer that we need in order to save the file once we've received it. If you save/view the PDF response without this, it just appears as a blank document.I've hacked working solution together here that gets this to work by allowing the user to pass in the transport directly (and defaults back to
text
when it's not provided).The text was updated successfully, but these errors were encountered: