removing deprecated gulp-util #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! But some test failed |
|
I didn't realize vinyl 2.0 removed the .pipe() function. So I put vinyl to 1.2.0 where .pipe() still exists. |
demurgos
approved these changes
Jan 11, 2018
| "through2": "^0.4.1", | ||
| "unzipper": "^0.7.1" | ||
| "unzipper": "^0.7.1", | ||
| "vinyl": "^1.2.0" |
There was a problem hiding this comment.
I cannot realize known for vinyl downgrade.
But OK, I merge and release it.
terrierscript
approved these changes
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18
gulp-util has been deprecated recently. Continuing to use this dependency may prevent the use of your library with the latest release of Gulp 4 so it is important to replace gulp-util.
The README.md lists alternatives for all the components so a simple replacement should be enough.
Your package is popular but still relying on gulp-util, it would be good to publish a fixed version to npm as soon as possible.
See:
https://medium.com/gulpjs/gulp-util-ca3b1f9f9ac5
gulpjs/gulp-util#143