Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize apply vs impute distinctions #89

Open
rofinn opened this issue Oct 21, 2020 · 1 comment
Open

Generalize apply vs impute distinctions #89

rofinn opened this issue Oct 21, 2020 · 1 comment
Milestone
1.0

Comments

@rofinn
Copy link
Member

rofinn commented Oct 21, 2020

Rather than having completely different APIs (e.g., apply vs impute) for Chain, Imputors, Filter, Validators, etc maybe we should just define a common API apply convention for all these types and distinguish them with functions like return_type, ccr (consume construct return), ismutating? We currently have mostly duplicated default behaviour for Imputors, Validators and declaremissings. This will just get worse once the current set of deprecations are completely removed. We also have only slight differences in the autogenerated functional API which could probably be simplified.
@rofinn rofinn changed the title Generalize apply, impute distinctions Generalize apply vs impute distinctions Oct 21, 2020
@rofinn
Copy link
Member Author

rofinn commented Oct 21, 2020

NOTE: Since this should mostly just reduce code duplicate and possible improve efficiency I don't think it'd be a breaking change to introduce in a future release. I'm going to leave this off the 0.6 milestone.

@rofinn rofinn added this to the 1.0 milestone Oct 21, 2020
@rofinn rofinn mentioned this issue Nov 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@rofinn