Skip to content
This repository has been archived by the owner on Apr 18, 2023. It is now read-only.

Test for unary_check() for tan function breaking on Julia v1.8 #220

Open
BaileyBox opened this issue Sep 28, 2022 · 4 comments
Open

Test for unary_check() for tan function breaking on Julia v1.8 #220

BaileyBox opened this issue Sep 28, 2022 · 4 comments

Comments

@BaileyBox
Copy link

BaileyBox commented Sep 28, 2022

When running the tests for this package under Julia version 1.8, Nabla version 0.12.3, 3 tests fail.

Using the tan function when calling unary_check() breaks on the 5th iteration of the loop here.

unary_check() just calls the check_errs() function here.

The error received is as follows:

Screen Shot 2022-09-29 at 1 18 43 PM

NOTE: "rando" is the value from the randx() function created right before entering this for loop. Since rng is always the same, these numbers are consistent.

The other 2 errors occur when also running tests in Julia version 1.6.

Here's an examples of the occurring errors:

From the Scalar tests:

Screen Shot 2022-09-29 at 1 21 50 PM

From the Functional tests:

Screen Shot 2022-09-29 at 1 22 04 PM

@BaileyBox
Copy link
Author

BaileyBox commented Sep 28, 2022

This comment can be ignored, as it applies to what's on master.

Screen Shot 2022-09-28 at 3 19 35 PM

Here's an example screenshot of an error from the - test. What's called in oneslike as an arg seems crazy wrong to me.

@BaileyBox
Copy link
Author

BaileyBox commented Sep 28, 2022

This comment can be ignored, as it applies to what's on master.

Screen Shot 2022-09-28 at 3 24 02 PM

Here's another example, but for the cholesky tests. More oddities with the typing, but instead of it being Base.Broadcast... differently typed.

@oxinabox
Copy link
Member

Note the version of Nabla we use in prod is not the master branch which is a bit fragile from the way we did the ChainRules integration, but rather the the - previous minor release.
Which while not as trivially extensible does just enough for prod and is well tested

@BaileyBox
Copy link
Author

BaileyBox commented Sep 29, 2022

Oops! Totally forgot to switch to the latest minor version! I remember there still being some tests failures for v0.12.3. Should I close this issue and make a new one? Or just delete some of the comments, and make some edits to this one? @oxinabox :)

Edit: Nvm, updated the issue to reflect usage of Nabla version 0.12.3.

@BaileyBox BaileyBox changed the title Tests breaking on Julia v1.8 test for unary_check() for tan function breaking on Julia v1.8 Sep 29, 2022
@BaileyBox BaileyBox changed the title test for unary_check() for tan function breaking on Julia v1.8 Test for unary_check() for tan function breaking on Julia v1.8 Sep 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants