New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: test case for missing after_configured signal #55

Open

lnielsen opened this issue Sep 5, 2016 · 0 comments

Labels

Need: tests Size: hard Status: ready for work Type: bug

Milestone

Member

lnielsen commented Sep 5, 2016 •

edited

Loading

These lines needs a test case.

Description of bug:

sa.orm.configure_mappers() sends the after_configured signal only if there are new model classes
SQLAlchemy-Continuum relies on after_configured signal to call configure_versioned_classes() which builds the model version classes.
If all models have been loaded and sa.orm.configure_mappers() has been called prior to SQLAlchemy-Continuum being initialised, then the versioned classes will not be created without this extra call

The text was updated successfully, but these errors were encountered:

lnielsen added Type: bug Status: ready for work Size: hard Need: tests labels

lnielsen added this to the v1.0.0 milestone

lnielsen mentioned this issue

ext: versioning initialization fix + release v1.0.0b2 #53

Merged

lnielsen modified the milestones: v1.0.0, someday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment