Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename get_locale selector to select_locale #123

Open
rekt-hard opened this issue Jul 4, 2023 · 2 comments
Open

rename get_locale selector to select_locale #123

rekt-hard opened this issue Jul 4, 2023 · 2 comments

Comments

@rekt-hard
Copy link
Contributor

Note: I would really rename invenio_i18n.selectors.get_locale to select_locale, since this might avoid the confusion.

Originally posted by @slint in #121 (comment)

Also need to checkout other modules which are using this selector
@ghost
Copy link

ghost commented Mar 21, 2024 •
edited by ghost
Loading

Does anything speak against this? @rekt-hard @zzacharo @ntarocco

@zzacharo
Copy link
Member

Discussed during InvenioRDM workshop 2024:

  • Deprecate the method get_locale
  • Add a method set_locale and gradually iterate through every package and start using the new method.
  • Once all packages have been migrated, then we can remove the deprecated method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zzacharo @rekt-hard