Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datamodel: treating internal fields with _ #38

Closed
ppanero opened this issue Nov 28, 2019 · 3 comments · Fixed by #49
Closed

datamodel: treating internal fields with _ #38

ppanero opened this issue Nov 28, 2019 · 3 comments · Fixed by #49

Comments

@ppanero
Copy link
Member

ppanero commented Nov 28, 2019

Currently the internal fields are prefix with underscore. However, the user submits the record without them (e.g. access).

An issue also arises when displaying the record. Currently the record view shows the record with _access.

  • Marshmallow?
  • Record API class?
@ppanero
Copy link
Member Author

ppanero commented Dec 10, 2019

@fenekku during some chat for on other topics, this matter arised. One point on favour of using _ is to "tell" harvesters which fields they should ignore because they are used for the internal operations / working functionality of the repository.

(I know we agreed to do it anyway, but is nice to know more points in favour of it :) )

@fenekku
Copy link
Contributor

fenekku commented Dec 10, 2019

Ok. I will add this to the agenda for tomorrow perhaps.

@fenekku
Copy link
Contributor

fenekku commented Dec 11, 2019

Metadata and details will be discussed at January meeting.

@fenekku fenekku mentioned this issue Dec 20, 2019
16 tasks
@ppanero ppanero mentioned this issue Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants