Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB printer support #29

Closed
timmyhadwen opened this issue Oct 20, 2023 · 8 comments · Fixed by #36
Closed

USB printer support #29

timmyhadwen opened this issue Oct 20, 2023 · 8 comments · Fixed by #36

Comments

@timmyhadwen
Copy link

Currently this plugin only supports networked printers however the brother_ql library supports USB printers as well. I have tested this by changing the send_label function.

@SchrodingersGat
Copy link
Member

@timmyhadwen interesting, would you be able to submit a PR to provide USB functionality?

@timmyhadwen
Copy link
Author

I have a fork with just hardcoded values for device address etc. More than happy to complete that implementation with settings etc however just struggling to get the plugin installed in a development environment? Do you have any tips for easy dev of plugins etc? I am currently using Docker and have the plugin cloned into the plugins folder but alas it won't install properly and can't see a nice way to get logs out. Any help or pointing in the right direction would be great :)

@SchrodingersGat
Copy link
Member

If you have the plugin cloned directly into the external "plugins" directory, it won't detect and load, as it is buried too "deep" in the directory structure.

Put the invenrtee_brother subdirectory into the "plugins" directory, and then it should load. Can you check if this works for you?

@wolflu05
Copy link

wolflu05 commented Nov 1, 2023

The easiest thing for me is using devcontainers in combination with editable installs. I described them on the docs a while ago: https://docs.inventree.org/en/stable/develop/devcontainer/?h=devcont#plugin-development

@SchrodingersGat
Copy link
Member

@timmyhadwen did you get it working?

@timmyhadwen
Copy link
Author

Thanks for your help guys. Work has been busy but hoping to get into a few PRs over the Christmas break. Will update soon.

@RealNagus
Copy link
Contributor

Hello. I needed the USB connection as well and implemented an additional setting for the plugin. Seems to work fine. You find the changes in my fork, if you're still interested I can create a PR.

@SchrodingersGat
Copy link
Member

@RealNagus a PR would be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants