Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain node typings to node-only code and dom typings to browser-only code #1375

Open
jakehamtexas opened this issue Aug 27, 2021 · 1 comment
Open

Constrain node typings to node-only code and dom typings to browser-only code #1375

jakehamtexas opened this issue Aug 27, 2021 · 1 comment

Comments

@jakehamtexas
Copy link
Contributor

Context

See for some context: #1374

Because the dom library is included in the root tsconfig.json, there are typings in server-side only node which should not exist. This can make it hard to debug issues where the browser typings are masking that an object is possibly undefined.

Recommendation

Split the root tsconfig.json into a server and browser version and propagate the change downstream to the project, or otherwise confine node typings to server-only library code, and dom typings to browser-only library code.
@jakehamtexas jakehamtexas changed the title Constraint node typings to node-only code and dom typings to browser-only code Constrain node typings to node-only code and dom typings to browser-only code Aug 27, 2021
@tonyhallett
Copy link
Contributor

Agreed #1311 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Inversify maintenance
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonyhallett @jakehamtexas