Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inversify-express-utils] HMR issue #1454

Open
Diukas opened this issue Apr 27, 2022 · 0 comments
Open

[inversify-express-utils] HMR issue #1454

Diukas opened this issue Apr 27, 2022 · 0 comments

Comments

@Diukas
Copy link

Diukas commented Apr 27, 2022

Hey, I'm experiencing issues with inversify-express-utils library, when application is running with HMR enabled and you make changes to controllers the application crashes because of duplicate Reflect metadata.

Expected Behavior

When application is reloaded through HMR the constructor should remove previous Reflect metadata and add new one.

Current Behavior

Making change to controller with HMR enabled duplicates Reflect metadata and checks for unique controller fails.

Possible Solution

Add de-duplication logic in decorators.ts

image

Steps to Reproduce (for bugs)

  1. Add controller class
  2. Launch application with HMR enabled
  3. Make changes to controller class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant