Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow version #29

Closed
benadamstyles opened this issue Apr 4, 2017 · 2 comments
Closed

Flow version #29

benadamstyles opened this issue Apr 4, 2017 · 2 comments

Comments

@benadamstyles
Copy link
Contributor

Hello! Thanks for all your hard work on this. Great to see your fork graduate to a proper package!

The latest version of flow used by react-native is 0.40. Running this version against my codebase, I'm getting ~42 flow errors in react-native-firebase. I'd love to help you fix these, but I'm not sure which version of flow you're working to. It could be that if I upgraded to 0.42, there would be no react-native-firebase errors, but then I wouldn't be able to flow-check my code because react-native is pinned to flow@0.40.

Would it make sense to add [version] ^0.40.0 to this package's .flowconfig, to ensure that it matches with react-native? Then I can start submitting PRs 🙂
@Ehesp
Copy link
Member

Ehesp commented Apr 4, 2017

Hey, yeah that sounds good. I don't actually think we worked to a flow version, just whatever we had on our macs at the time (woops).

@benadamstyles
Copy link
Contributor Author

Submitted a PR with further discussion

@birgernass birgernass mentioned this issue Aug 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ehesp @benadamstyles