-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 [Question] How to remove AdMob SDK #3617
Comments
We are facing the same issue. Any updates about that? |
I think this needs to be directed more upstream at https://github.com/firebase/firebase-android-sdk/ |
Hi @Tyki, hi @mikehardy For test purposes, I removed the firebase dependency and the warning has gone. So the problem was somewhere in the library. Only solution for me was update React Native version to 0.62.2 (I suppose any version higher than 0.60 will fit too) and react-native-firebase to 6.7.1 I still have Now my project files look like this. Project files
package.json
android/build.gradle
android/app/build.gradle
|
So for their support you do need a minimal reproduction using just the native SDKs, yes
This is an assumption, it could have still been in their transitive dependency chain, which we necessarily depend on. And it may have just been older versions of their native libraries, as a possible alternative explanation
That version is still out of date, all the versions are 7+ now, definitely worth keeping current as the 6.x versions are on older native firebase SDKs so you're still running pretty old code #3575 in particular might interest you and is present in v7+ only per the tags on the merged commit 35285f1
I'm running RNFBv7+ with the firebase native packages overridden to be most current (25.4.1 right now) and I still have 17.0.0 on that dep though, so that seems pretty current So you may have some tidying to do, but in general this seems resolved? |
Hello 👋, to help manage issues we automatically close stale issues.
|
Sorry to write on a closed ticket, let me know if I have to proceed differently...but I have the same warning. My package.json related to this library states:
and
(Please note the com.google.android.gms:play-services-ads-identifier:17.0.0). No idea if this can be related to the warning message. Another interesting question to ask is: does this Google warning affects the rank/position in the Store (according to your experience)? Thanks. |
Why is this issue closed? it is not yet resolved. |
Hi guys. This issue is closed because the solution was found - updating React Native version. It was a hard task, but it helped me. Unfortunately, I have no info on why the issue exists in React Native < v0.60.0 |
Looks like this issue is not resolved. Google Play displays AdMob warning with these versions:
|
create a minimal reproduction and post it to firebase-android-sdk repo I think, @iqqmuT - or a minimal reproduction here with an |
It's the same dependency chain as @IYarosh mentioned in the 1st post:
If that is the case, I just don't understand why |
Worth noting you are on old versions, you might investigate why your firebase-android-sdk BOM is out of date, I'm getting 17.5.0 versions for most of that stack, but it otherwise looks similar I believe the play-services-ads-identifier is different from the ads sdk It is interesting that the original reporter stated this:
That indicates to me that it is (or was?) possible to have the ads identifier in your dependencies without getting any warning. I have ads-identifier in my dependencies, and I receive no such warning in my project on the play console. If someone could post exactly what this warning is, along with any supporting material linked to the warning, that could help. |
For clarity: Version: 30202 is the version code of the app, not of AdMob SDK. |
Hello @paour I know that you have issue with react native sdk, My answer is related to native one, if react-native sdk providers follow these steps at their end, he can release react native sdk without these warning. I have follow all steps mentioned in below link and I don't have a warning from google now. https://stackoverflow.com/a/64798971/1252275 Its for information only, Hope it will help others. |
This issue is definitely not resolved. We have "react-native": "0.63.2" and "@react-native-firebase/app": "^8.4.1" and still see the warning |
We are on v10.1.0 now, you don't specify the version of the firebase-ios-sdk you are using (v7.1.0 is current) or firebase-android-sdk (26.1.0 is current), and you don't mention if you have any other modules included @EugeneDGE - in short, not a great issue report, I can't take any action on it. Upgrade to current, attempt to reproduce, and if you do please file a new issue following the template - we can take a look |
Currently am using the latest version still i have the same problem "@react-native-firebase/analytics": "^10.1.1", We found ad SDKs in your app |
Please note @usuf16 that part of the initial issue template here is a full Podfile. In this case a Podfile.lock could even help, though I can say:
It should work. This area of issues is stale at this point, everyone has gotten their apps approved and moved on I think, so it should be possible. I'm never sure why a specific project isn't working but I know it's possible with react-native-firebase |
@mikehardy Thanks!! am agree with your commands that am not using react-native latest version My question is that just i need a clarification on @react-native-firebase/admob": "^10.1.1" am not using this plugin in the app but still its highlighted that admob present in current uploaded app. Reference i found in "index.android.bundle" APP_NATIVE_MODULE='RNFBAppModule';e.DEFAULT_APP_NAME='[DEFAULT]';e.KNOWN_NAMESPACES=['admob','auth','analytics','remoteConfig','crashlytics','database','inAppMessaging','firestore','functions','iid','indexing','storage','dynamicLinks','messaging','naturalLanguage','ml','notifications','perf','utils']},556,[]); |
You're not using inAppMessaging either, but that's in the KNOWN_NAMESPACES because it is a KNOWN_NAMESPACE to react-native-firebase. Means nothing more, don't overthink that. Check your Podfile.lock for google-mobile-ads-sdk, and in the tree of dependencies encoded in Podfile.lock why it's coming in. The full issue template (which you have not filled in and or provided info for) would have shown if you were overriding the firebase-ios-sdk anywhere. 7.3.0 is current, you should use that. Or at worst, if you update to react-native-firebase 10.2.0 you'll get firebase-ios-sdk 7.2.0 Either way, there is not an issue with react-native-firebase. Your project may have something wrong, but I can't say what. I won't be able to provide further support |
Hello, I am using the latest version of react-native (0.63.4) and the latest version of @react-native-firebase/app (^10.8.0) and I am getting the same issue : We found ad SDKs in your app |
@Helyios do not post on closed issues with insufficient details (i.e., all the things we would want in the full issue template). It does not provide us with anything to go on to help. You might examine the 'no IDFA' mode of my demo script https://github.com/mikehardy/rnfbdemo/blob/3b1095089e898c7629b8d530e1ad07b7998415d6/make-demo.sh#L11-L14 |
Is there any update about this issue? I'm getting warning in Google Play that app is using AdMob. |
@Luckygirlllll the comment right above yours is the current state of this closed issue:
|
If I modify the build.gradle file here
then the Is there anyway to modify it without modifying it inside the firebase analytics package inside node_modules? |
If this is a requirement and there's documentation upstream on how to do this (please link) then adding a gradle build variable that the script uses to determine whether to include it or not as a PR could work, similar to how we allow override of the firebase-android-sdk bom version |
I don't have much idea about gradle build scripts. I found the solution for excluding Could you guide me if possible where to make the changes so that I don't have to modify node_modules folder to exclude the |
@adar2378 for now for android I can only recommend using patch-package (though that's a strong recommendation: it works great, I use it personally) to make your fix "production-worthy" until the upstream issue is fixed https://github.com/ds300/patch-package Then moving it forward it appears that you want to do two things:
I do confirm (via
|
Issue
Hi,
I want to remove Advertising SDK from my android app.
I'm using Firebase SDK and Analytics in the app.
On Google Play Market Console I have a warning that the app uses Advertising SDK.
To check it I run this command in android folder
gradle app:dependencies
to check dependency tree. In console output I have something like that
I'm not a very good user of gradle, but as I understand, firebase-core have firebase-analytics dependency, which have play-services-measurement and so on and finally have play-services-ads-identifier dependency.
So when I bundle the app, I also have play-services-ads-identifier in my app. I think it can be the reason why Google Market believes that I use Advertising SDK
So my question is it possible to remove Advertising SDK and left only Core and Analytics?
Project files
package.json dependencies:
android/build.gradle
android/app/build.gradle
Environment:
OS: macOS Mojave 10.14.4 (18E2034)
node: 12.16.2
npm: 6.14.4
Gradle: 5.5.1
The text was updated successfully, but these errors were encountered: