Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): remove deprecated usages of APPLICATION_ID #3711

Merged
merged 1 commit into from
May 29, 2020

Conversation

Salakar
Copy link
Member

@Salakar Salakar commented May 29, 2020

Description

In preparation for Android Studio v.4.0.0 release today.

Related issues

Fixes #3254.

Supersedes PR #3710.

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

In preparation for Android Studio v.4.0.0 release today.
@Salakar Salakar changed the title refactor(android): remove deprecated usages of APPLICATION_ID fix(android): remove deprecated usages of APPLICATION_ID May 29, 2020
@Salakar Salakar merged commit 984d3fc into master May 29, 2020
@Salakar Salakar deleted the @salakar/android-app-id branch May 29, 2020 03:41
stefkampen pushed a commit to stefkampen/react-native-firebase that referenced this pull request Jun 6, 2020
…#3711)

Removed in preparation for Android Studio v.4.0.0 release today.

[publish]
andersondanilo pushed a commit to vixtech/react-native-firebase that referenced this pull request Nov 9, 2020
…#3711)

Removed in preparation for Android Studio v.4.0.0 release today.

[publish]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot find symbol BuildConfig.APPLICATION_ID
1 participant