Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android,ios): upgrade native SDK versions #3881

Merged
merged 36 commits into from
Jul 7, 2020
Merged

Conversation

andersonaddo
Copy link
Contributor

I did this mostly to solve #3614 for everyone. Is this all that's required?

I think this should be fine, since the tests already override to SDK v6.27.0.

Looking at the changelog, I think the only changes that might change the dev experience are:

Installations change 3

Remote Config change 1

Storage change 2

mikehardy
mikehardy previously approved these changes Jul 5, 2020
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks right to me so I approve though it be even more awesome if it included the similar android bump - here's the template to follow from the last one https://github.com/invertase/react-native-firebase/pull/3663/files - android is at 25.5.0 as of this typing

And as promised your 🎺 and 👼 singing 🎶 :-)

@andersonaddo
Copy link
Contributor Author

andersonaddo commented Jul 5, 2020

Doesn't look like there's been a new BoM for Android since 25.5.0

Ooops - Now i get what you mean 😅. On it

@Salakar
Copy link
Member

Salakar commented Jul 5, 2020

Thanks for this, LGTM, though could you change https://github.com/invertase/react-native-firebase/blob/master/packages/app/package.json#L70 as well, thanks

@andersonaddo
Copy link
Contributor Author

Added the Android upgrade.
Note that this drops support for Gradle v4

@mikehardy
Copy link
Collaborator

I think gradle is on v6 now, so that's okay, react-native hasn't been on v4 for a while? Should be fine?
Ah wait! facebook/react-native@b4017a9

react-native 0.60 was the first to use it. So there are a few people using RNFBv6+ with RN59-, they need a warning that they will have to override things, so this is a major version bump for android :-)

But version numbers are free! Just needs a changelog entry warning IMHO

@Salakar
Copy link
Member

Salakar commented Jul 6, 2020

LGTM

I wonder if we even need to major version this, I thought v6 was RN 60 min with 59 as "it works" - can't find the support table anywhere though 🙈 so can't confirm

@mikehardy
Copy link
Collaborator

I think you are right, if RN59 is not officially supported, you could just put a very obvious change note for RN59 people. That seems friendly enough. It's a fail-fast as well they'll find out quite quickly, not like an obscure prod only runtime issue

@Salakar Salakar changed the title chore(ios): upgraded SDK version to 6.27.0 feat(android,ios): upgraded native SDK versions Jul 6, 2020
@Salakar Salakar changed the title feat(android,ios): upgraded native SDK versions feat(android,ios): upgrade native SDK versions Jul 6, 2020
@Salakar Salakar merged commit 6cb68a8 into master Jul 7, 2020
@andersonaddo andersonaddo deleted the andersonaddo-patch-2 branch July 7, 2020 15:16
andersondanilo pushed a commit to vixtech/react-native-firebase that referenced this pull request Nov 9, 2020
[publish]

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
andersondanilo pushed a commit to vixtech/react-native-firebase that referenced this pull request Nov 9, 2020
[publish]

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
[publish]

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
[publish]

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Sep 15, 2021
[publish]

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants