Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashlytics documentation for setUserName and setUserEmail is possibly outdated #3908

Closed
emeraldsanto opened this issue Jul 8, 2020 · 4 comments · Fixed by #3909
Closed

Comments

@emeraldsanto
Copy link
Contributor

emeraldsanto commented Jul 8, 2020

Documentation Feedback

I was using a previous version of the Crashlytics module which provided methods such as setUserName and setUserEmail. After updating to the latest version 8.1.1 which migrated away from Fabric, these 2 methods no longer exist. I already worked around the problem by setting those fields using the setAttributes method.

I wonder if that's simply a documentation issue or a regression that was introduced in the latest version.

Cheers!

@mikehardy
Copy link
Collaborator

Needs a doc update that didn't ship as part of the PR, commented here #3580 (review)

If you have a moment can you hit the edit button on top right of the page and post up a PR for the changes pleeeeease :-) 🙏

@andersonaddo
Copy link
Contributor

It's a documentation issue actually - those two methods were purposefully removed.

You can use the edit button at the top of the docs page to submit a super quick PR 😁

@emeraldsanto
Copy link
Contributor Author

Coolio, thanks for letting me know. I've opened #3909.

@andersonaddo
Copy link
Contributor

Wow @mikehardy I just realized we added those comments at pretty much the exact same time, haha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants