Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Crashlytics setup broken link #3970

Closed
mconiglio opened this issue Jul 17, 2020 · 6 comments
Closed

iOS Crashlytics setup broken link #3970

mconiglio opened this issue Jul 17, 2020 · 6 comments
Labels
plugin: crashlytics Firebase Crashlytics

Comments

@mconiglio
Copy link

Documentation Feedback

Hello. First of all thank you for creating this libraries, they all work great, and the documentation is awesome!

I'm using the firebase/app (7.2.1), firebase/analytics (7.1.4) and firebase/crashlytics (7.1.5) packages on a RN 0.59.2 app. Android works well, but I'm facing an issue now where the dSYMs aren't being uploaded to the Crashlytics console.

I added the a script to the build phases as detailed in the docs that has this:
"${PODS_ROOT}/Fabric/run"

I noticed that there were some changes on the Crashlytics implementation on the last versions, and that the script ran the command upload-symbols, which now is not under Fabric, but under the FirebaseCrashlytics pod.

I was guessing that maybe upgrading to the last version of the RN firebase/crashlytics package could solve the problem, though I'm not sure about it (any guidance on this would be super helpful 🙏).

But when reading the last version of the docs about the iOS setup, and the dSYMs files upload step I didn't found anything. Not even the old Fabric/run script call. And I noticed that the "iOS additional config steps" link is broken (under this section).

If you could give any guidance on this it would help a lot. I'm not sure if upgrading to the last version is the solution to this, or maybe I'm just missing something on the setup for the upload-symbols script to work as expected.

Thanks in advance for your help, and again for creating this set of libraries!

@mikehardy
Copy link
Collaborator

Hi there!

You are integrating an outdated version of crashlytics 😨
But also, uploading dSYMS is in general not useful these days, worth mentioning: https://stackoverflow.com/questions/54577202/how-to-run-upload-symbols-to-upload-dsyms-as-a-part-of-xcode-build-process/55796619#55796619

We don't officially support RN59 for RNFBv6+ but that likely doesn't affect these docs

I believe this section of the docs was updated for #3580 ?

@mconiglio
Copy link
Author

Thanks for the info @mikehardy! Yes, I'm using this version of the firebase package because I configured it like a month ago or maybe even more. I don't have the possibility to upgrade the RN version right now due to the nature of the project, but I'm aware of the troubles it implies sometimes.

I read your answer on SO, but this error appears on the Crashlytics console if I don't upload the dSYMs:
image

Despite the RN version, and considering your answer on SO... do you think that the best choice should be to upload the dSYMs files manually by downloading them from AppStore connect? Or do you have any other recommendation?

@mikehardy
Copy link
Collaborator

mikehardy commented Jul 18, 2020

My answer on SO is unequivocal, in the dSYM era if you do not somehow get the app-store-generated dSYMs into crashlytics post-upload-to-the-app-store, your work has no effect.

I recommend fastlane

@mconiglio
Copy link
Author

Ok, thanks for the answer. I was just thinking that maybe the upload script can still be useful for the AppCenter (or other similar tools) builds, despite it's not useful for the AppStore ones. That's the main reason of my question.

@mikehardy
Copy link
Collaborator

Hmmm I was not thinking there was a viable pathway on to an iDevice except app store but if there are other avenues then I suppose those could use the dSYMs from the build, but at that point you've got two dSYMs pathways, is that viable? Wouldn't it be better to have one? Perhaps fastlane has plugins for all your use cases.

@andersonaddo andersonaddo added the plugin: crashlytics Firebase Crashlytics label Jul 18, 2020
@mconiglio
Copy link
Author

Ok, thanks for the info. I guess the best thing would be to use Fastlane and maybe customize the scripts a little depending on if it's a build for AppCenter or a build for the AppStore. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin: crashlytics Firebase Crashlytics
Projects
None yet
Development

No branches or pull requests

3 participants