fix: making auth and firestore observable compatible

[zhigang1992]

Description

Official firebase-js-sdk support observer as a form of callback, we have partial support on Firestore's onSnapshot.

But it wasn't 100% inline with js-sdk, for example. previously, we were just passing observer.next directly. which will cause problem if that function has reference to observer via this. Adding bind(this) should do the trick

Related issues

#2066

Release Summary

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[zhigang1992]

No very sure on where to put this type

[zhigang1992]

also not sure where to put this utils function.

[mikehardy]

Hi there!

E2E test failure, possibly related? I haven't reviewed the PR yet - but was working on CI yesterday and wanted to see if the CI failure was false negative or real, so it's all I've examined so far:

  1) firestore().doc().onSnapshot()
       throws if SnapshotListenerOptions is invalid:
     Error: Did not throw an Error.
      at Context.<anonymous> (/Users/runner/work/react-native-firebase/react-native-firebase/packages/firestore/e2e/DocumentReference/onSnapshot.e2e.js:302:29)
      at processImmediate (internal/timers.js:456:21)

[zhigang1992]

Hi there!

E2E test failure, possibly related? I haven't reviewed the PR yet - but was working on CI yesterday and wanted to see if the CI failure was false negative or real, so it's all I've examined so far:

  1) firestore().doc().onSnapshot()
       throws if SnapshotListenerOptions is invalid:
     Error: Did not throw an Error.
      at Context.<anonymous> (/Users/runner/work/react-native-firebase/react-native-firebase/packages/firestore/e2e/DocumentReference/onSnapshot.e2e.js:302:29)
      at processImmediate (internal/timers.js:456:21)

Yeah, fixed now.

[Salakar]

Nice, thanks for sending this over

[mikehardy]

LGTM too - the test support exercising it is great, very much appreciated

[mikehardy]

@zhigang1992 - strange - I'm not sure if this is related to your change or not, but the current CI failure might be?

  1) firestore().collection().onSnapshot()
       unsubscribes from further updates:
     AssertionError: expected Function { name: '' } to be called thrice but was called 4 times
    spy([object Object], null) at handleSuccess (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&sourceMapURL=true:202068:11)
    spy([object Object], null) at handleSuccess (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&sourceMapURL=true:202068:11)
    spy([object Object], null) at handleSuccess (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&sourceMapURL=true:202068:11)
    spy([object Object], null) at handleSuccess (http://localhost:8081/index.bundle?platform=android&dev=true&minify=false&sourceMapURL=true:202068:11)
  

[mikehardy]

Same thing happened on #1039 - I think it's a flaky test so I'm re-running the job and linking it to #4058 for attention

[mikehardy]

Working through a merge of all PRs that are ready, will take a while (probably in to tomorrow) to finish that, then I'll do the release. Thanks again @zhigang1992 !