feat(analytics): add 'logScreenView' API and deprecate setCurrentScreen API.

[russellwheatley]

WIP. I'll request a review once I have a bit more feedback.

Description

• deprecated setCurrentScreen API. iOS & Android
• added logScreenView

Related issues

Release Summary

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/46mcdvn95
✅ Preview: https://react-native-firebase-git-russell-analytics-update.invertase.vercel.app

[mikehardy]

all documentation comments :-)

[mikehardy]

saw one little comment nit to pick :-)

[mikehardy]

Still WIP or good-to-go @russellwheatley :-) ? I could give it a final review pass and if it looks good maybe get it out...

[russellwheatley]

It should pass I think. Android tests flaked out last time so fingers crossed this time 🤞

[mikehardy]

Flaked again, on one I've seen - tracking flake cause here and rerunning #4058 (comment)

[mikehardy]

LGTM - will merge this as soon as E2E cooperates, or...I guess I'll have lots of fresh inspiration for de-flaking E2E ;-)

[MoKhajavi75]

Hey
Thanks for your efforts!

I just see the new docs and for React Navigation, we should use just class_name but we use both of screen_name and screen_class for React Native Navigation!
That is the correct behavior or I should create a PR for that missing line 😁?

cc @mikehardy

[mikehardy]

@MohamadKh75 I'm not sure screen class is that useful. But it is a valid parameter. How did it work when you tried it? (what did it look like in analytics, in other words)

[MoKhajavi75]

Well, I just upgraded to the newest version and use both screen_name and screen_class! I should wait some time to get the analytics report.
Maybe @Salakar has an idea!

[mikehardy]

I think it will just work. I don't believe there will be "novel" information. It should be the same screen tracking events, just from a different API call. Honestly, it is supposed to be an exceptionally boring change, just forward-porting to new underlying API calls.

[MoKhajavi75]

So, should I create a PR to add that to React Navigation?

[mikehardy]

That is up to you? If React Navigation has any sort of documentation that cross-links with react-native-firebase here, and it needs an update, then sure. It's a different / unrelated repo so nothing I say is really authoritative, right?

[MoKhajavi75]

I mean in here 😁

[mikehardy]

@MohamadKh75 Sure! DIdn't realize it was actually our example :-)