Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): Added test case for orderby before where query #4459

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

dackers86
Copy link
Member

Query validators are ineffective when using a where clause after an order by clause. This PR investigates and adds tests cases to prove the logic.

See issue #3220

@vercel
Copy link

vercel bot commented Oct 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/f8pjr1y9b
✅ Preview: https://react-native-firebas-git-dackers86-where-order-by-invest-4c400c.invertase.vercel.app

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6a8f8ad). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4459   +/-   ##
=========================================
  Coverage          ?   41.92%           
=========================================
  Files             ?       35           
  Lines             ?     1119           
  Branches          ?      278           
=========================================
  Hits              ?      469           
  Misses            ?      489           
  Partials          ?      161           

@mikehardy mikehardy changed the title fix(firestore) Added test case for orderby before where query fix(firestore): Added test case for orderby before where query Nov 10, 2020
mikehardy
mikehardy previously approved these changes Nov 10, 2020
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mikehardy
Copy link
Collaborator

@dackers86 I just brought this one up to date with main branch, and the test was still it.only plus was not using it's own collection so it was muddled with other results when not it.only so I altered the collection ref to be unique, then it passed -> merging!

@mikehardy mikehardy marked this pull request as ready for review November 10, 2020 16:39
@mikehardy mikehardy merged commit fdf978a into master Nov 10, 2020
@mikehardy mikehardy deleted the @dackers86/where-order-by-investigation branch November 10, 2020 16:41
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants