Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Firebase Android library firebase-core is no longer needed. #4593

Closed
rnike opened this issue Nov 23, 2020 · 2 comments · Fixed by #4597
Closed

The Firebase Android library firebase-core is no longer needed. #4593

rnike opened this issue Nov 23, 2020 · 2 comments · Fixed by #4597
Labels
help: needs-triage Issue needs additional investigation/triaging. platform: android type: bug New bug report Workflow: Waiting for User Response Blocked waiting for user response.

Comments

@rnike
Copy link
Contributor

rnike commented Nov 23, 2020

According to the firebase release notes
Screen Shot 2020-11-23 at 5 50 07 PM

Shall it be removed from the @react-native-firebase/app dependencies?

@react-native-firebase/app/android/build.gradle

dependencies {
  implementation platform("com.google.firebase:firebase-bom:${ReactNative.ext.getVersion("firebase", "bom")}")
-  implementation "com.google.firebase:firebase-core"
  implementation "com.google.firebase:firebase-common"
  implementation "com.google.android.gms:play-services-auth:${ReactNative.ext.getVersion("play", "play-services-auth")}"
}
@rnike rnike added help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report labels Nov 23, 2020
@mikehardy
Copy link
Collaborator

Hi there!
You can reach in to node_modules and edit the file to try it, if it works, make a PR for the same and then if that passes CI (it should? according to the release notes) then I can merge and release it

@rnike
Copy link
Contributor Author

rnike commented Nov 23, 2020

@mikehardy Sure, here comes the PR.

I've run tests:android:build and tested on an app and see nothing wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help: needs-triage Issue needs additional investigation/triaging. platform: android type: bug New bug report Workflow: Waiting for User Response Blocked waiting for user response.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants