Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Make additional non-fatal error generation on JS exception optional #4904

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

sergey-kozel
Copy link
Contributor

Description

Currently, the crashlytics react-native package generates an additional non-fatal issue on JS crashes that might cause issues duplication and absence of collected logs for original exceptions. This PR introduces an option in firebase.json to prevent the module from generating that additional error.

Related issues

Fixes #4772

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Feb 11, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/9wztql5n9
✅ Preview: https://react-native-f-git-fork-sergey-kozel-optional-error-gene-e2c0fc.invertase.vercel.app

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #4904 (86780cb) into master (0446e44) will increase coverage by 0.41%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4904      +/-   ##
==========================================
+ Coverage   88.63%   89.04%   +0.41%     
==========================================
  Files         109      109              
  Lines        3720     3721       +1     
  Branches      347      348       +1     
==========================================
+ Hits         3297     3313      +16     
+ Misses        381      365      -16     
- Partials       42       43       +1     

@mikehardy mikehardy added Workflow: Pending Merge Waiting on CI or similar and removed Workflow: Pending Merge Waiting on CI or similar labels Feb 11, 2021
@mikehardy mikehardy merged commit 63c35b3 into invertase:master Feb 11, 2021
@mikehardy
Copy link
Collaborator

will be in 10.8.x the next time I hit the publish button - should be in the next couple of days (I try to batch changes a bit, while at the same time not waiting too long once I've merged something...)

@mikehardy
Copy link
Collaborator

@sergey-kozel I think you in particular might like the new crashlytics feature we just released in v11.3 - https://invertase.io/blog/react-native-firebase-crashlytics-configuration - your feature is still there to de-duplicate the "chained exception handler" case, but if you don't have a specific chained exception behavior you want, you might like the new JS fatal crash + no-chained-exception-handler possibility.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] Crashlytics log is not working for Android
2 participants