-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app, android): fixes possible crash on first launch #4990
fix(app, android): fixes possible crash on first launch #4990
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/2AnipZUa6ifn4MpepL94D5wqzksb |
Codecov Report
@@ Coverage Diff @@
## master #4990 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 109 109
Lines 3721 3721
Branches 348 348
=======================================
Hits 3311 3311
Misses 369 369
Partials 41 41 |
Hi @JiboStore - thank you for this! Can you follow the information here to sign the CLA? We can't merge without that step #4990 (comment) |
@JiboStore not to pester, I just know things get lost in all the notifications we all get. And you've done great work here, I'd like to merge it in but need the CLA signed - see above for instructions. Cheers! |
@mikehardy I have signed the CLA, on my side, it shows that |
I think it was I who missed it! Everything does look green thank you! |
Description
Fix crash on first run on Android-11 when
context.getExternalFilesDir(null);
returns nullRelated issues
Fixes #4979
Release Summary
PR title
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter