Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't send Item price to analytics #5227

Closed
artemkhalygov opened this issue Apr 28, 2021 · 5 comments
Closed

Can't send Item price to analytics #5227

artemkhalygov opened this issue Apr 28, 2021 · 5 comments
Labels
help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report

Comments

@artemkhalygov
Copy link
Contributor

Issue

Why it's impossible to add price to the Item inside viewItemList? As I can see in documentation https://firebase.google.com/docs/analytics/measure-ecommerce#javascript - it should be possible.

image

But the current Item structure doesn't have a price. Maybe I'm wrong but it should be here, isn't it?

export interface Item {
    item_brand?: string;
    item_id?: string;
    item_name?: string;
    item_category?: string;
    item_category2?: string;
    item_category3?: string;
    item_category4?: string;
    item_category5?: string;
    item_list_id?: string;
    item_list_name?: string;
    item_location_id?: string;
    item_variant?: string;
    quantity?: number;
 }

Thanks.

Project Files

Javascript

Click To Expand

package.json:

    "@react-native-firebase/analytics": "^11.2.0",
    "@react-native-firebase/app": "^11.2.0",
    "@react-native-firebase/dynamic-links": "^11.2.0",
    "@react-native-firebase/messaging": "^11.2.0",
@artemkhalygov artemkhalygov added help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report labels Apr 28, 2021
@mikehardy
Copy link
Collaborator

Have you checked the issues list? There is some good discussion on this one if I recall correctly

@artemkhalygov
Copy link
Contributor Author

@mikehardy Yes, I am. But I found only this PR that related to my issue #4536

I'm almost sure that price also should be added.

@mikehardy
Copy link
Collaborator

I will happily work with you to merge a PR implementing the things you need, the PR you linked could be a good template to do so

You may be interested in the comments on a related issue, starting here: #4578 (comment)

@artemkhalygov
Copy link
Contributor Author

@mikehardy Agree with you, that I can fix it myself

So I created a PR #5232

@mikehardy
Copy link
Collaborator

Fixed by #5232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report
Projects
None yet
Development

No branches or pull requests

2 participants