Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app, android): support list of Activities to ignore when detecting AppState #5235

Merged
merged 16 commits into from
Apr 29, 2021

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Apr 29, 2021

Description

This is entirely based off the good work from @danwhite-ipc on #5228 - just doing a branch here so I can push one final change to it - I don't have write powers on that branch

From that PR:

Allow for configuration of background native activities to allow for the handling of background messages when a native activity is visible and the react native app is dead.

Related issues

Supercedes #5228 but verified the CLA was signed.
Fixes #5219

Release Summary

PR title is conventional, squash merge

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Relying on @danwhite-ipc to indicate it works for them :-), I added a test array key to the test app firebase.json and it gets a background message during E2E testing, so that should at least exercise the JSON parse code


Think react-native-firebase is great? Please consider supporting the project with any of the below:

danwhite-ipc and others added 15 commits April 28, 2021 15:37
…e/common/SharedUtils.java

Co-authored-by: Mike Hardy <github@mikehardy.net>
…e/common/SharedUtils.java

Co-authored-by: Mike Hardy <github@mikehardy.net>
…e/common/SharedUtils.java

Co-authored-by: Mike Hardy <github@mikehardy.net>
…e/common/SharedUtils.java

Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: Mike Hardy <github@mikehardy.net>
…e/common/ReactNativeFirebaseJSON.java

Co-authored-by: Mike Hardy <github@mikehardy.net>
…e/common/SharedUtils.java

Co-authored-by: Mike Hardy <github@mikehardy.net>
…e/common/SharedUtils.java

Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: Mike Hardy <github@mikehardy.net>
…e/common/SharedUtils.java

Co-authored-by: Mike Hardy <github@mikehardy.net>
@vercel
Copy link

vercel bot commented Apr 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/DcanRUBryKUjLhmALjrLixEWB6Gb
✅ Preview: https://react-native-f-git-mikehardy-ipcortexfeaturebackgroundac-1729ba.vercel.app

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #5235 (ba8e100) into master (574f691) will not change coverage.
The diff coverage is n/a.

❗ Current head ba8e100 differs from pull request most recent head 550be73. Consider uploading reports for the commit 550be73 to get more accurate results

@@           Coverage Diff           @@
##           master    #5235   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files         109      109           
  Lines        3743     3743           
  Branches      360      360           
=======================================
  Hits         3326     3326           
  Misses        370      370           
  Partials       47       47           

lint check addition for NewApi saved the day on this one, I did
not see it until CI failed
@mikehardy mikehardy merged commit 50a384f into master Apr 29, 2021
@mikehardy mikehardy deleted the @mikehardy/ipcortex/feature/backgroundActivityNames branch April 29, 2021 21:14
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Apr 29, 2021
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
…ng AppState (invertase#5235)

* Check json config for background activities
* Add json config key to test app to exercise code

Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: Dan White <40389335+danwhite-ipc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setBackgroundMessageHandler not working with multiple native Activities
2 participants