-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): admob shows only non-personalized ads #5262
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/ANG54Bz9Rr7i95eHygLHZsGKGvik |
Codecov Report
@@ Coverage Diff @@
## master #5262 +/- ##
=======================================
Coverage 36.63% 36.63%
=======================================
Files 51 51
Lines 1521 1521
Branches 361 361
=======================================
Hits 557 557
Misses 734 734
Partials 230 230 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a 🤦 issue. Nice catch
Description
On iOS the actual value of requestNonPersonalizedAdsOnly is never checked (it just checks if the key was set), which results in AdMob showing only non-personalized ads.
On Android it's already checking for the actual Boolean value of requestNonPersonalizedAdsOnly.
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__