Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): admob shows only non-personalized ads #5262

Merged
merged 6 commits into from
May 4, 2021

Conversation

dylancom
Copy link
Contributor

@dylancom dylancom commented May 4, 2021

Description

On iOS the actual value of requestNonPersonalizedAdsOnly is never checked (it just checks if the key was set), which results in AdMob showing only non-personalized ads.
On Android it's already checking for the actual Boolean value of requestNonPersonalizedAdsOnly.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

@vercel
Copy link

vercel bot commented May 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/ANG54Bz9Rr7i95eHygLHZsGKGvik
✅ Preview: https://react-native-firebase-git-fork-dylancom-master-invertase.vercel.app

@dylancom dylancom changed the title fix: admob shows only non-personalized ads (iOS) fix(ios): admob shows only non-personalized ads May 4, 2021
@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #5262 (16adb07) into master (684bb50) will not change coverage.
The diff coverage is n/a.

❗ Current head 16adb07 differs from pull request most recent head 701f702. Consider uploading reports for the commit 701f702 to get more accurate results

@@           Coverage Diff           @@
##           master    #5262   +/-   ##
=======================================
  Coverage   36.63%   36.63%           
=======================================
  Files          51       51           
  Lines        1521     1521           
  Branches      361      361           
=======================================
  Hits          557      557           
  Misses        734      734           
  Partials      230      230           

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a 🤦 issue. Nice catch

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label May 4, 2021
@mikehardy
Copy link
Collaborator

iOS E2E is not working because it's based on an old version of my buildcache work #5239 before I used tokens to fetch the release in #5257 which I merged after this forked - I pulled it locally and it's 💯 - merging - thanks again!

@mikehardy mikehardy merged commit 0b62d5a into invertase:master May 4, 2021
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants