Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, json-schema): admob_delay_app_measurement_init type is boolean #5297

Merged
merged 1 commit into from
May 12, 2021

Conversation

mikehardy
Copy link
Collaborator

Description

Fixes #5295 - credit @DoctorJohn thanks!

Commit message says it all, more details in linked issue if needed

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented May 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/GyhFU2ih8DDCYVXEq7xeUZAzEXey
✅ Preview: https://react-native-f-git-mikehardy-json-schema-admob-delay-typ-be064a.vercel.app

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #5297 (691e0a6) into master (34344dd) will decrease coverage by 2.88%.
The diff coverage is n/a.

❗ Current head 691e0a6 differs from pull request most recent head dbaf209. Consider uploading reports for the commit dbaf209 to get more accurate results

@@            Coverage Diff             @@
##           master    #5297      +/-   ##
==========================================
- Coverage   82.99%   80.11%   -2.87%     
==========================================
  Files         109      109              
  Lines        4137     4137              
  Branches      439      439              
==========================================
- Hits         3433     3314     -119     
- Misses        657      752      +95     
- Partials       47       71      +24     

@mikehardy mikehardy merged commit d931b48 into master May 12, 2021
@mikehardy mikehardy deleted the @mikehardy/json-schema-admob-delay-type branch May 12, 2021 18:26
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label May 12, 2021
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛] admob_delay_app_measurement_init wrongly typed in json schema
1 participant