fix(firestore, types): allow FieldValues, Date and Timestamp in doc set and update

[Yonom]

Description

This is a fix for Typescript types to remove the following two errors:

type BarType = {
  myDate: FirebaseFirestoreTypes.Timestamp;
};

const docRef = firebase.firestore().doc<BarType>(`${COLLECTION}/bar`);
await docRef.set({
  myDate: new Date(), // TS2739 Type 'Date' is missing the following properties from type 'Timestamp', [...]
});
await docRef.set({
  myDate: firestore.FieldValue.serverTimestamp(),// TS2739 Type 'FieldValue' is missing the following properties from type 'Timestamp', [...]
});

Related issues

Release Summary

fix(firestore): Adjust types to allow setting FieldValues and allow Date in place of Timestamp

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

Run tests.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/D9mD8xtQ31vHnakkpXipt8boBxJr
✅ Preview: Canceled

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/FBNoDvWXYhU2yEBzxtSRQEHu6JqJ
✅ Preview: https://react-native-firebase-git-fork-yonom-firestore-fd8227-invertase.vercel.app

[codecov]

Codecov Report

Merging #5901 (abd553c) into main (f24a204) will increase coverage by 28.01%.
The diff coverage is n/a.

❗ Current head abd553c differs from pull request most recent head a6142e2. Consider uploading reports for the commit a6142e2 to get more accurate results

@@              Coverage Diff              @@
##               main    #5901       +/-   ##
=============================================
+ Coverage     24.61%   52.62%   +28.01%     
- Complexity        0      620      +620     
=============================================
  Files            97      208      +111     
  Lines          4230    10154     +5924     
  Branches       1026     1612      +586     
=============================================
+ Hits           1041     5343     +4302     
- Misses         2587     4553     +1966     
+ Partials        602      258      -344     

[mikehardy]

This LGTM after review (and note upstream types are here https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore-types/index.d.ts though we are a little divergent and perhaps they are either not handling this well or are handling it via any-ification)

I've seen this myself though and your test lends me confidence. I have a medium success ratio track record with type changes, sometimes a tiny change even intended to be non-breaking results in something else popping up from someone else, so we'll have to keep eyes/ears open post release. Should be fine though? 🤞