-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app, expo): Support RN 0.68 Obj-C++ AppDelegate #6213
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #6213 +/- ##
============================================
+ Coverage 52.92% 52.97% +0.06%
Complexity 622 622
============================================
Files 208 208
Lines 10220 10221 +1
Branches 1626 1625 -1
============================================
+ Hits 5408 5414 +6
+ Misses 4558 4553 -5
Partials 254 254 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! I really appreciate the ongoing help @barthap - no way I could keep up with Expo too at the moment, but I'm impressed they're adopting 0.68+ so quickly after being stuck on 0.64 so long! Good to see
I'm marking the PR as a "fix" semantic-release type, so I can kick out a patch-release and get it out there post-merge 🚀 |
Description
Expo SDK 45 will be based on React Native 0.68, which has AppDelegate written in Objective-C++ (Renamed
AppDelegate.m
->AppDelegate.mm
). The file content changes are fortunately insignificant for us.@expo/config-plugins
to4.1.1
which already supports Objective-C++ App delegates (commit)if (language === 'objc')
changed toif (['objc', 'objcpp'].includes(language))
Release Summary
AppDelegate.mm
and SDK 45.Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Unit tests pass (
yarn tests:jest
)