Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, expo): Support RN 0.68 Obj-C++ AppDelegate #6213

Merged
merged 5 commits into from
Apr 25, 2022

Conversation

barthap
Copy link
Contributor

@barthap barthap commented Apr 25, 2022

Description

Expo SDK 45 will be based on React Native 0.68, which has AppDelegate written in Objective-C++ (Renamed AppDelegate.m -> AppDelegate.mm). The file content changes are fortunately insignificant for us.

  • Bumped @expo/config-plugins to 4.1.1 which already supports Objective-C++ App delegates (commit)
  • The only significant change in the plugin code: if (language === 'objc') changed to if (['objc', 'objcpp'].includes(language))
  • Rest of the PR are the tests - did a small refactor and added some tests to check proper language support.

Hopefully no more changes are required for plugins to work with upcoming SDK 45, but I'll keep an eye on it

Release Summary

  • Expo iOS plugin now supports React Native 0.68 Objective-C++ AppDelegate.mm and SDK 45.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Unit tests pass (yarn tests:jest)

@vercel
Copy link

vercel bot commented Apr 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-native-firebase ✅ Ready (Inspect) Visit Preview Apr 25, 2022 at 1:23PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-native-firebase-next ⬜️ Ignored (Inspect) Apr 25, 2022 at 1:23PM (UTC)

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #6213 (62b52d6) into main (f0adecc) will increase coverage by 0.06%.
The diff coverage is 85.72%.

❗ Current head 62b52d6 differs from pull request most recent head a27e7a0. Consider uploading reports for the commit a27e7a0 to get more accurate results

@@             Coverage Diff              @@
##               main    #6213      +/-   ##
============================================
+ Coverage     52.92%   52.97%   +0.06%     
  Complexity      622      622              
============================================
  Files           208      208              
  Lines         10220    10221       +1     
  Branches       1626     1625       -1     
============================================
+ Hits           5408     5414       +6     
+ Misses         4558     4553       -5     
  Partials        254      254              

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! I really appreciate the ongoing help @barthap - no way I could keep up with Expo too at the moment, but I'm impressed they're adopting 0.68+ so quickly after being stuck on 0.64 so long! Good to see

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Apr 25, 2022
@mikehardy mikehardy changed the title chore(app, expo): Support RN 0.68 Obj-C++ AppDelegate fix(app, expo): Support RN 0.68 Obj-C++ AppDelegate Apr 25, 2022
@mikehardy
Copy link
Collaborator

I'm marking the PR as a "fix" semantic-release type, so I can kick out a patch-release and get it out there post-merge 🚀

@mikehardy mikehardy merged commit 6f2d7e1 into invertase:main Apr 25, 2022
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Apr 25, 2022
@barthap barthap deleted the patch-2 branch April 26, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants