-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(messaging, ios): Support Ephemeral authorization state #6478
fix(messaging, ios): Support Ephemeral authorization state #6478
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is basically perfect - and I appreciate your patience, I'm just getting caught up over here after summer travel. I made a nitpick/tiny suggestion that I should be able to apply myself, then we can get this merged
Codecov Report
@@ Coverage Diff @@
## main #6478 +/- ##
=============================================
- Coverage 54.90% 25.83% -29.07%
=============================================
Files 208 97 -111
Lines 10358 4291 -6067
Branches 1645 1048 -597
=============================================
- Hits 5686 1108 -4578
+ Misses 4371 2583 -1788
- Partials 301 600 +299 |
I just tacked on a commit with diff from |
There is no reason the android emulator should fail, and after a couple retries it seems to be fully busted at the moment, something I just fixed in another project. Going to defer that here but since it didn't touch any android stuff, will merge |
Description
Adds support for the authorization status
UNAuthorizationStatusEphemeral
that was introduced with iOS 14. This status can be returned for App Clips, and means that notifications are allowed for a limited amount of time. See https://developer.apple.com/documentation/app_clips/enabling_notifications_in_app_clipsRelated issues
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter