fix(firestore): fix an issue where using FieldPath in orderBy would lead to a native error being thrown
#6814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
mikehardy
reviewed
Jan 4, 2023
mikehardy
reviewed
Jan 4, 2023
Lyokone
changed the title
FieldPath in orderBy would lead to a native error being thrown
Codecov Report
@@ Coverage Diff @@
## main #6814 +/- ##
============================================
- Coverage 54.42% 54.05% -0.37%
+ Complexity 700 691 -9
============================================
Files 218 218
Lines 10800 10814 +14
Branches 1700 1707 +7
============================================
- Hits 5877 5844 -33
- Misses 4610 4677 +67
+ Partials 313 293 -20 |
mikehardy
approved these changes
Jan 10, 2023
| export function extractFieldPathData(data, segmenets) { | ||
| export function extractFieldPathData(data, segments) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of always transforming the orderBy into a String, I allow the bridge to keep the reference to a FieldPath in order to be able to use FieldPath in native also.
Related issues
closes #6602
Release Summary
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter