-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(analytics): Add types to modular package #7109
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4de5e58
to
a46bc54
Compare
a46bc54
to
330bfb0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #7109 +/- ##
============================================
+ Coverage 53.80% 54.21% +0.42%
Complexity 735 735
============================================
Files 231 231
Lines 11629 11633 +4
Branches 1864 1867 +3
============================================
+ Hits 6256 6306 +50
+ Misses 5026 4981 -45
+ Partials 347 346 -1 |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly comments + questions, and one stated preference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still some tangential spacing changes mixed with the diff, still hoping for a link to authoritative reference for string constants
Appears to have taken conflicts as I added |
Additional modifications to AppDelegate.mm are required in order to load the RNFBAppCheckModule. Without initializing the AppCheckModule before calling [FIRApp configure], the setup of a custom provider will fail.
…returns void not Promise<void>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still not ready to go - I saw a couple things I did not see before and there was an unanswered question
The merge commits make the commit change indecipherable in general and the spacing changes make the combined diff difficult to look at but I reviewed it again nonetheless
Please check the new comments and we can get this in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typedefs are used to get clean types in the jsdoc now, Nabeel got the reference to the upstream event names in there, just pending CI
d27ece3
to
5de86f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI went green but I had a copy/paste error in last push, fixed re-pushed and good to go
Description
See title
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__