Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, ios): bump iOS SDK to v10.22.0 #7668

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

VictorioMolina
Copy link
Contributor

@VictorioMolina VictorioMolina commented Mar 5, 2024

Description

Since yesterday, we have been getting errors when trying to create an iOS build:

(/Users/expo/workingdir/build/packages/app/ios/Pods/FirebaseStorage/FirebaseStorage/Sources/Storage.swift:73:12)

  71 |     let provider = ComponentType<StorageProvider>.instance(for: StorageProvider.self,
  72 |                                                            in: app.container)
> 73 |     return provider.storage(for: Storage.bucket(for: app))
     |            ^ value of optional type '?' must be unwrapped to refer to member 'storage' of wrapped base type 'any StorageProvider'
  74 |   }
  75 | 
  76 |   /**

It seems that this issue has already been fixed in the Firebase iOS SDK.

See: firebase/firebase-ios-sdk@1ed6d66

guard let provider = ComponentType<StorageProvider>.instance(for: StorageProvider.self,
                                                                 in: app.container) else {
      fatalError("No \(StorageProvider.self) instance found for Firebase app: \(app.name)")
    }
    return provider.storage(for: Storage.bucket(for: app, urlString: url))

Related issues

Release Summary

Upgrade firebase iOS SDK from v10.21.0 to v10.22.0

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 3:48am

@VictorioMolina VictorioMolina changed the title fix(storage): bump iOS SDK to v10.22.0 fix(storage, ios): bump iOS SDK to v10.22.0 Mar 5, 2024
@VictorioMolina VictorioMolina changed the title fix(storage, ios): bump iOS SDK to v10.22.0 fix(storage): bump iOS SDK to v10.22.0 Mar 5, 2024
@VictorioMolina VictorioMolina requested a review from womj March 6, 2024 04:55
Copy link

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

in practice this file is out of date and causes failures more often
than having it survive the install is useful.

github actions cache will still pull from the secondary key and get
reasonable caching behavior even if the lockfile hash changes
@mikehardy
Copy link
Collaborator

iOS passed, doc lint passed, the changes won't affect anything else (pass or fail), so this is good to go

Thank you @VictorioMolina !

@mikehardy mikehardy merged commit 3fc756b into invertase:main Mar 7, 2024
18 of 19 checks passed
@mikehardy mikehardy changed the title fix(storage): bump iOS SDK to v10.22.0 fix(app, ios): bump iOS SDK to v10.22.0 Mar 7, 2024
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Mar 7, 2024
@VictorioMolina
Copy link
Contributor Author

@mikehardy thx, everything working now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants