-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app, ios): bump iOS SDK to v10.22.0 #7668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
VictorioMolina
changed the title
fix(storage): bump iOS SDK to v10.22.0
fix(storage, ios): bump iOS SDK to v10.22.0
Mar 5, 2024
VictorioMolina
changed the title
fix(storage, ios): bump iOS SDK to v10.22.0
fix(storage): bump iOS SDK to v10.22.0
Mar 5, 2024
womj
approved these changes
Mar 6, 2024
3imed-jaberi
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
in practice this file is out of date and causes failures more often than having it survive the install is useful. github actions cache will still pull from the secondary key and get reasonable caching behavior even if the lockfile hash changes
iOS passed, doc lint passed, the changes won't affect anything else (pass or fail), so this is good to go Thank you @VictorioMolina ! |
mikehardy
changed the title
fix(storage): bump iOS SDK to v10.22.0
fix(app, ios): bump iOS SDK to v10.22.0
Mar 7, 2024
@mikehardy thx, everything working now :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since yesterday, we have been getting errors when trying to create an iOS build:
It seems that this issue has already been fixed in the Firebase iOS SDK.
See: firebase/firebase-ios-sdk@1ed6d66
Related issues
Release Summary
Upgrade firebase iOS SDK from v10.21.0 to v10.22.0
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__