-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(messaging, ios): fixed isHeadless for react-native-navigation #7868
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@mikehardy Can you take a look? |
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
Well it’s not my fault if no one looks at it |
@mikehardy you said you’d approve such pull request a while back to fix the issue, can you take a look at this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Beat-YT - seems fair enough to me. Need to fix linting failure. There's a script in package.json you need to run: yarn lint:ios:fix
. Waiting for CI run to see what else pops up.
@russellwheatley I have fixed linting failure a you requested. |
Can you check this out @russellwheatley |
As an FYI; I ran app and tested messages in foreground and background which worked as intended. There are no ways to test this e2e so it was a manual check. |
Description
Related issues
fixes #6429
Release Summary
Moved the setter of
isHeadless
to before the check for rctView that does not exists on react-native-navigationChecklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
I sent a remote notification with content-available to true, and then I also opened the app before it shut itself down to test that it does set itself to false as well.
p.s: Sorry for the double pull request, I read through the CONTRIBUTING.md a bit too fast 😅