-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storage): ensure emulator is used for different storage buckets #7892
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a great fix, thanks
I squashed the commits into a single unit mostly for the chance to re-push so it would re-trigger CI after rebasing on to current main
Hopefully that clears the iOS test error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is an other platform fail like the others could we just skip it conditionally for that platform? historically we have not cleaned up TODOs with much velocity and I'm worried we'll lose this coverage here on all platforms for an extended period when - if I understand correctly - this is just because of other platform issues?
if (Platform.other) {
// TODO - remove once "other" is fully integrated
this.skip();
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message codes, not message codes + message text are the new standard for error assertions, so this is 💯
Description
Related issues
fixes #7717
Release Summary
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter