Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): ensure emulator is used for different storage buckets #7892

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jul 11, 2024

Description

Related issues

fixes #7717

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 2:58pm

@russellwheatley russellwheatley changed the title tests: write e2e tests for testing 2nd storage bucket is used on emul… fix(storage): ensure emulator is used for different storage buckets Jul 11, 2024
mikehardy
mikehardy previously approved these changes Jul 14, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a great fix, thanks
I squashed the commits into a single unit mostly for the chance to re-push so it would re-trigger CI after rebasing on to current main
Hopefully that clears the iOS test error

Lyokone
Lyokone previously approved these changes Jul 15, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is an other platform fail like the others could we just skip it conditionally for that platform? historically we have not cleaned up TODOs with much velocity and I'm worried we'll lose this coverage here on all platforms for an extended period when - if I understand correctly - this is just because of other platform issues?

      if (Platform.other) {
        // TODO - remove once "other" is fully integrated
        this.skip();
      }

@mikehardy mikehardy added Workflow: Waiting for User Response Blocked waiting for user response. and removed Workflow: Pending Merge Waiting on CI or similar labels Jul 15, 2024
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message codes, not message codes + message text are the new standard for error assertions, so this is 💯

@mikehardy mikehardy removed the Workflow: Waiting for User Response Blocked waiting for user response. label Jul 15, 2024
@mikehardy mikehardy merged commit 3fa3f11 into main Jul 15, 2024
19 checks passed
@mikehardy mikehardy deleted the storage-7717 branch July 15, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛]🔥 Storage emulator is not used when uploading to non-default bucket
3 participants