fix(firestore): Filter typing. Filter.or & Filter.and can accept each other

[russellwheatley]

Description

Related issues

fixes #7850

Release Summary

Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Yes
• My change supports the following platforms;
  • Android
  • iOS
• My change includes tests;
  • e2e tests added or updated in packages/\*\*/e2e
  • jest tests added or updated in packages/\*\*/__tests__
• I have updated TypeScript types that are affected by my change.
• This is a breaking change;
  • Yes
  • No

Test Plan

---

Think react-native-firebase is great? Please consider supporting the project with any of the below:

• 👉 Star this repo on GitHub ⭐️
• 👉 Follow React Native Firebase and Invertase on Twitter

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-native-firebase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2024 10:58am

[mikehardy]

This is divergent from the type system firebase-js-sdk uses, QueryFilterConstraint should be composed of QueryCompositeFilterConstraint already, and not need a change.

Current def of QueryFilterConstraint should be changed/renamed similar to upstream QueryFieldFilterConstraint then QueryFilterConstraint is composed of both of them...

https://github.com/firebase/firebase-js-sdk/blob/84fe88079842d2840a10eccc865c78bca2653f35/packages/firestore/src/lite-api/query.ts#L356-L392

I always look at judge typing changes by looking through firebase-js-sdk until I find their declarations and then seeing whether we are getting closer or father away from what they're doing - goal being to do exactly what they are doing unless we have some react-native-specific reason to deviate ?

[mikehardy]

Great - this looks like it has a lot more fidelity with the firebase-js-sdk type system and should allow and/or to also accept and/or