Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): support for PersistentCacheIndexManager #7910

Merged
merged 26 commits into from
Aug 13, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jul 16, 2024

Description

  1. Created new persistentCacheIndexManager() API that returns instance of FirestorePersistentCacheIndexManager. This returns null if the user has set persistence to false in Firestore settings. Persistence is enabled by default.
  2. Created modular API that matches naming on firebase js sdk for the FirestorePersistentCacheIndexManager.
  3. Updated both legacy and modular index.d.ts files for new API.
  4. Wrote tests that prove the logic.

Related issues

closes #7737

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 9:26am

exaby73
exaby73 previously approved these changes Jul 30, 2024
exaby73
exaby73 previously approved these changes Aug 5, 2024
Lyokone
Lyokone previously approved these changes Aug 12, 2024
exaby73
exaby73 previously approved these changes Aug 12, 2024
@russellwheatley russellwheatley enabled auto-merge (squash) August 13, 2024 09:57
@russellwheatley russellwheatley merged commit 0b0de45 into main Aug 13, 2024
19 checks passed
@russellwheatley russellwheatley deleted the firestore-index-configuration branch August 13, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: support index manager APIs for firestore
3 participants