Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): support for second database #7949

Merged
merged 23 commits into from
Aug 9, 2024
Merged

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jul 29, 2024

Description

  • Used existing code to allow firestore to accept an argument (i.e databaseId).
  • Update index.d.ts & modular/index.d.ts type files.
  • Prepend databaseId to every native method call alongside appName for Firestore
  • Updated macOS code to match.
  • Tested 2nd database by creating 3 new test files based on the following existing test files:

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 0:40am

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! That's an epic. Looks great to me

@russellwheatley russellwheatley merged commit eec08a0 into main Aug 9, 2024
21 checks passed
@russellwheatley russellwheatley deleted the firestore-second-db branch August 9, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants