Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): openAdInspector returns Promise, not function #123

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix(types): openAdInspector returns Promise, not function #123

merged 1 commit into from
Apr 28, 2022

Conversation

wjaykim
Copy link
Collaborator

@wjaykim wjaykim commented Apr 28, 2022

Description

Fixes wrong return type of openAdInspector method in MobileAds class.

Related issues

Release Summary

fix wrong openAdInspector method return type

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #123 (ec46f06) into main (80a5692) will not change coverage.
The diff coverage is n/a.

❗ Current head ec46f06 differs from pull request most recent head cc4aa81. Consider uploading reports for the commit cc4aa81 to get more accurate results

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   23.01%   23.01%           
=======================================
  Files          32       32           
  Lines         765      765           
  Branches      188      184    -4     
=======================================
  Hits          176      176           
  Misses        589      589           

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense :-), it's not returning a listener-unsubscriber :-), thanks for this @wjaykim

@mikehardy mikehardy changed the title fix: fix wrong openAdInspector method return type fix(types): openAdInspector returns Promise, not function Apr 28, 2022
@mikehardy mikehardy merged commit ccbf881 into invertase:main Apr 28, 2022
github-actions bot pushed a commit that referenced this pull request Apr 28, 2022
### [6.0.1](v6.0.0...v6.0.1) (2022-04-28)

### Bug Fixes

* **types:** openAdInspector returns Promise, not function ([#123](#123)) ([ccbf881](ccbf881))
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wjaykim wjaykim deleted the fix-inspector-type branch April 28, 2022 13:18
Star-dev325 added a commit to Star-dev325/react-native-google-mobile-ads that referenced this pull request Jun 7, 2024
### [6.0.1](invertase/react-native-google-mobile-ads@v6.0.0...v6.0.1) (2022-04-28)

### Bug Fixes

* **types:** openAdInspector returns Promise, not function ([#123](invertase/react-native-google-mobile-ads#123)) ([ccbf881](invertase/react-native-google-mobile-ads@ccbf881))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants