feat(android): potentially improves mediation performance for banners #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/react-native-google-mobile-ads~527 Documentation is deployed and generated using docs.page. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
=======================================
Coverage 43.66% 43.66%
=======================================
Files 29 29
Lines 536 536
Branches 147 147
=======================================
Hits 234 234
Misses 302 302 |
|
@birdofpreyru ! Sorry for the delay on this and anything else you've posted, haven't had any time lately. Will spin through them shortly and collaborate + work to get these merged as promised. Thanks for your patience |
mikehardy
approved these changes
Feb 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
## [12.11.0](v12.10.0...v12.11.0) (2024-02-19) ### Features * **android:** potentially improves mediation performance for banners ([#527](#527)) ([32f550a](32f550a)) ### Bug Fixes * **consent:** the package returns the wrong value for consent for 'Create a personalized content profile' purpose ([7aef863](7aef863))
|
🎉 This PR is included in version 12.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Star-dev325
added a commit
to Star-dev325/react-native-google-mobile-ads
that referenced
this pull request
Jun 7, 2024
## [12.11.0](invertase/react-native-google-mobile-ads@v12.10.0...v12.11.0) (2024-02-19) ### Features * **android:** potentially improves mediation performance for banners ([#527](invertase/react-native-google-mobile-ads#527)) ([32f550a](invertase/react-native-google-mobile-ads@32f550a)) ### Bug Fixes * **consent:** the package returns the wrong value for consent for 'Create a personalized content profile' purpose ([7aef863](invertase/react-native-google-mobile-ads@7aef863))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A little refactoring of the banner initialization code for Android, motivated by AdMob docs for mediation.
Related issues
Fixes #506
Release Summary
Potentially improves mediation performance for banners on Android.
Checklist
and followed the process outlined there for submitting PRs.
AndroidiOSe2etests added or updated in__tests__e2e__jesttests added or updated in__tests__Test Plan
I ran the example app after update, it works fine. The change is also quite trivial.
Think
react-native-google-mobile-adsis great? Please consider supporting the project with any of the below:Invertaseon Twitter