Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #496

Open
paulojamorim opened this issue Jan 23, 2023 · 6 comments
Open

Add unit tests #496

paulojamorim opened this issue Jan 23, 2023 · 6 comments

Comments

@paulojamorim
Copy link
Collaborator

paulojamorim commented Jan 23, 2023

Use tools like unittest or pytest to add tests to InVesalius code. That way, when adding new features or bug fixes, you can verify that no previous code has been affected. Also run this code when committing and sending pull requests on Github.

https://realpython.com/python-testing/

@jLiucoder
Copy link

jLiucoder commented Feb 23, 2023

Hi!
I saw the Google Summer of Code posting and I am interested in participating in this part of the project, I am wondering if there are any more specific requirements for the participants that are interested in this?
Thanks!

@ericglem
Copy link

ericglem commented Feb 23, 2023

Hey guys!

I also saw the Google Summer of Code post and I'm also interested in contributing. Is there any other communication channels to discuss this?

@tfmoraes
Copy link
Member

We are using Github discussion for now.

@skat00sh
Copy link

skat00sh commented Mar 6, 2023

Hello,
Congrats of being selected in GSoC'23
I wanted to ask what code-coverage are you aiming for? A quick glance through the invesalius3/invesalius/, is giving me an idea that:

  1. /data and /gui -> Has the majority of the code that might require a combination of unit-testing and mocking as well
  2. segmentation is a DL(UNet) based approach, doesn't need unit-testing per say
  3. /invesalius has some parts that require testing
  4. /pubsub seems WIP may be for now

If there isnt' any preference set yet, PyTest could be a good option.
Setting up pre-commit hooks for formatting, say for e.g using Black could be another idea
A test directory will have to be created which would then be triggered and could be run using Github actions of any other CI/CD tool of choice when a PR is created.

Am I thinking in the right direction?

@simrann20
Copy link

Hey!

I am Simrann, a postgraduate student in CS and AI from IIITD. I am quite intrigued by this idea and am looking forward to contribute to it as a GSoC 2023 student!

@paulojamorim
Copy link
Collaborator Author

Hi @skat00sh and @simrann20 ,

We are using Github discussion for now. Anyway, @skat00sh the segmentation can have pre-segmented files to verify that the methods are working correctly.

@simrann20 , please follow the instructions: https://github.com/invesalius/gsoc/blob/main/gsoc_application.md

ATTENTION: New questions about GSoc 2023 most be asked in discussion: https://github.com/invesalius/invesalius3/discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants