Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reporting - THB symbol not formatted correctly #619

Open
shaneoreilly opened this issue Dec 12, 2023 · 5 comments
Open

[BUG] Reporting - THB symbol not formatted correctly #619

shaneoreilly opened this issue Dec 12, 2023 · 5 comments
Labels

Comments

@shaneoreilly
Copy link

shaneoreilly commented Dec 12, 2023

Setup

  • Version: v5.7.54-C141
  • Environment: Docker, self hosted

Interface

  • Flutter: []
  • React: []
  • Both: [X]

Checklist

Describe the bug

My currency is set as THB
When exporting to Excel, the THB symbol (฿) is being exported as a character, so I cannot do any formula calculations on the data without manual modifications to remove the ฿ character first.

Steps To Reproduce

  • Set Currency to THB
  • Export Invoice/Payment reports

Expected Behavior

  • The THB symbol (฿) should be exported correctly
    OR
  • Option should be given to remove any currency symbol on export

Additional context

Screenshots

Logs


@turbo124 turbo124 transferred this issue from invoiceninja/invoiceninja Dec 12, 2023
@hillelcoren
Copy link
Member

Are you exporting the data from Settings > Import/Export or from the reports?

Can you confirm this problem affects both the Flutter and React apps?

@shaneoreilly
Copy link
Author

@hillelcoren
The issue is there when exporting from "Reports", but I just validated the same issue is not there in the data exported via Settings -> Import/Export.
The values are numberic values without any ฿ currency string included.

I am using the Flutter UI on desktop. How can I switch back to React to test? I just assumed the export logic is independent of the UI being used

@hillelcoren
Copy link
Member

There's a React button at the top of the dashboard.

@shaneoreilly
Copy link
Author

Ah, simple. Thanks for that @hillelcoren!

I see the following:

No Issue:

  • React: Reports Dasboard:
  • React: Settings > Import/Export
  • Flutter: Settings > Import/Export

Issue Exists:

  • Flutter: Reports Dasboard:

@shrawank039
Copy link
Contributor

Payment Reports Using,

Flutter Panel:
Screenshot 2024-08-20 at 2 09 43 PM
React Panel:
Screenshot 2024-08-20 at 2 09 21 PM

as we see in react export there is a separate column for 'Payment Currency' which displays the currency ISO/symbol. And in the flutter export, It's set with the price.

So creating a separate column like react will fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants